Internal class aware coerceAs. Already used in nafill and froll

[jangorecki]

closes:

• class-aware C coercion function, no-alloc coerce where possible class-aware C coercion function, no-alloc coerce where possible #3913
• use new coerceAs in nafill
• use new coerceAs in froll
• (this is logically a distinct issue) Extend functionality of nafill to use 'fill' argument for all 'type's Extend functionality of nafill to use 'fill' argument for all 'type's #3594
• as of now partially: implicit type promotion in fcoalesce and fifelse implicit type promotion in fcoalesce and fifelse #4101
• verbose message from memrecycle requires verbose=3L or higher
• memrecycle no longer mentions column position and name when those are not provided
• coerceAs will suppress warning from memrecycle related to valid coercion nafill() should coerce fill="2" to 2L (for example) without warning #4503

[codecov]

Codecov Report

Merging #4491 (909add0) into master (3fa8b20) will decrease coverage by 0.06%.
The diff coverage is 93.28%.

@@            Coverage Diff             @@
##           master    #4491      +/-   ##
==========================================
- Coverage   99.46%   99.40%   -0.07%     
==========================================
  Files          73       73              
  Lines       14414    14417       +3     
==========================================
- Hits        14337    14331       -6     
- Misses         77       86       +9     

Impacted Files	Coverage Δ
R/shift.R	100.00% <ø> (ø)
src/utils.c	94.77% <80.43%> (-3.59%)	⬇️
R/data.table.R	99.94% <100.00%> (+<0.01%)	⬆️
R/wrappers.R	100.00% <100.00%> (ø)
src/assign.c	99.70% <100.00%> (-0.01%)	⬇️
src/frollR.c	99.48% <100.00%> (-0.05%)	⬇️
src/init.c	100.00% <100.00%> (ø)
src/nafill.c	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa8b20...909add0. Read the comment docs.

[jangorecki]

Yes, coerceAs is used to coerce fill argument to nafill and froll. Additionally it is used in froll to coerce x input to double.

[mattdowle]

Have seen the missed coverage in new coerceAs. Sounds like future PRs will address that.