Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

which=NA for not optimized i, closes #4411 #4430

Merged
merged 2 commits into from
Apr 19, 2021
Merged

which=NA for not optimized i, closes #4411 #4430

merged 2 commits into from
Apr 19, 2021

Conversation

jangorecki
Copy link
Member

closes #4411

@codecov
Copy link

codecov bot commented May 6, 2020 •
edited
Loading

Codecov Report

Merging #4430 (d9cdb90) into master (b1d25cd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4430   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          73       73           
  Lines       14444    14446    +2     
=======================================
+ Hits        14361    14363    +2     
  Misses         83       83
Impacted Files Coverage Δ
R/data.table.R 99.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1d25cd...d9cdb90. Read the comment docs.

MichaelChirico
MichaelChirico approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattdowle mattdowle added this to the 1.14.1 milestone Apr 19, 2021
@mattdowle mattdowle merged commit 01a1e03 into master Apr 19, 2021
@mattdowle mattdowle deleted the which-na-fix branch April 19, 2021 05:31
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

which=NA inconsistent with ?data.table
3 participants
@jangorecki @MichaelChirico @mattdowle