inner join now available with nomatch=NULL also, towards #857 #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3095 +/- ##
==========================================
+ Coverage 90.9% 90.92% +0.02%
==========================================
Files 61 61
Lines 11816 11817 +1
==========================================
+ Hits 10741 10745 +4
+ Misses 1075 1072 -3
Continue to review full report at Codecov.
|
This was referenced Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed off-gh I am suggesting to add support for
nomatch=NULLalready in current dev version. This PR does not include any new logic, just maps NULL tonomatch=0L. What it gives is future-proof API for inner join. We don't have any date for deprecatingnomatch=0L. Assuming it will happen at all, it will require few major release cycles. Related to #857.