Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handles integer vector stored as matrix in i, closes #826 #1275

Merged
merged 1 commit into from
Sep 14, 2015

Conversation

jangorecki
Copy link
Member

Simple and I believe completed solution to close #826

@arunsrinivasan
Copy link
Member

Could you please also add an item to NEWS, and add about this feature in the i argument of ?data.table? Thanks.

@jangorecki
Copy link
Member Author

The ?data.table is already covered by sentence:

Integer and logical vectors work the same way they do in [.data.frame.

So no update required I believe. It is a special case of integer vector with second dimension artificially created. Description of it can be more confusing. I will update NEWS and put that to into bugfixes as it is bugfix comparing to data.frame behaviour.

@arunsrinivasan
Copy link
Member

I'm not following. Where does it mention 1-col matrix? Why do you say it's artificially created? It's more confusing to see other matrices error, but not 1-col matrices.

@jangorecki
Copy link
Member Author

Readme, Rd and code prepared. Some sequence number (62:63 in bugfix and 1549 in tests) skipped to avoid conflicts with other PR.

@jangorecki
Copy link
Member Author

@arunsrinivasan
Copy link
Member

@jangorecki will take a look asap. You might want to resolve the conflicts in the meanwhile?

@jangorecki
Copy link
Member Author

@arunsrinivasan will try today/tomorrow

@arunsrinivasan
Copy link
Member

sure.

@jangorecki
Copy link
Member Author

Finally learned some rebase :) once travis pass I think it is ready to merge.

arunsrinivasan added a commit that referenced this pull request Sep 14, 2015
handles 1-col numeric matrices like data.frames, closes #826
@arunsrinivasan arunsrinivasan merged commit a401ca0 into Rdatatable:master Sep 14, 2015
@jangorecki jangorecki deleted the i_vec_as_matrix branch February 26, 2016 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] subset DT on integer vector stored as matrix the same way as data.frame
2 participants