-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handles integer vector stored as matrix in i, closes #826 #1275
Conversation
62cb946
to
666a39b
Compare
Could you please also add an item to NEWS, and add about this feature in the |
The
So no update required I believe. It is a special case of integer vector with second dimension artificially created. Description of it can be more confusing. I will update NEWS and put that to into bugfixes as it is bugfix comparing to data.frame behaviour. |
I'm not following. Where does it mention |
666a39b
to
ffdd7ca
Compare
Readme, Rd and code prepared. Some sequence number (62:63 in bugfix and 1549 in tests) skipped to avoid conflicts with other PR. |
ffdd7ca
to
c61b407
Compare
Looks like PR is right in time, see http://stackoverflow.com/questions/32509803/creating-a-data-partition-using-caret-and-data-table |
@jangorecki will take a look asap. You might want to resolve the conflicts in the meanwhile? |
@arunsrinivasan will try today/tomorrow |
sure. |
c61b407
to
dcce8fd
Compare
Finally learned some rebase :) once travis pass I think it is ready to merge. |
dcce8fd
to
0047caf
Compare
handles 1-col numeric matrices like data.frames, closes #826
Simple and I believe completed solution to close #826