revdep getDTeval affected

[mattdowle]

Same as #5125

On line 138 of getDTeval it does :

names(the.result) <- gsub(pattern = "`", replacement = "", x = names(the.result))

which drops the key and causes :

> test_check("getDTeval")
══ Failed tests ════════════════════════════════════════════════════════════════
── Failure (test-getDteval.R:68:2): create a new column ────────────────────────
getDTeval(...) not equal to formulaic::snack.dat[, `:=`(age_decades, floor(get(age.name)/10))].
Datasets has different number of (non-excluded) attributes: target 2, current 3

[ FAIL 1 | WARN 0 | SKIP 0 | PASS 4 ]
Error: Test failures
Execution halted

[tdhock]

git bisect says that this error started happening after merging #5084

[mattdowle]

Thanks for doing the bisect, but did you see #5133 linked above which mentions that?

[tdhock]

I didn't, thanks for the info, glad to see there is a fix in the works!

[mattdowle]

I remember struggling with it. Hopefully fresh eyes will help.

[MichaelChirico]

This still reproduces on current master + CRAN getDTeval, and not on CRAN data.table (1.14.10).

[MichaelChirico]

Minimized example (I didn't see a truly minimal example yet across the various issues & open PR)

DT <- data.table(a = 1)
setindex(DT, a)
names(DT) <- "b"
"index" %in% names(attributes(DT))
# on CRAN
# [1] TRUE
# on master
# [1] FALSE

[tdhock]

I believe we should keep this open until the revdep fixes this, or until it disappears from the revdep checker (currently still there) https://rcdata.nau.edu/genomic-ml/data.table-revdeps/analyze/2023-12-22/

[MichaelChirico]

Filed downstream: MB4511/getDTeval#1

[MichaelChirico]

Now fixed+verified: