Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fread stringsAsFactors=0.2 #2025

Closed
mattdowle opened this issue Feb 15, 2017 · 2 comments · Fixed by #2545
Closed

fread stringsAsFactors=0.2 #2025

mattdowle opened this issue Feb 15, 2017 · 2 comments · Fixed by #2545
Labels
feature request fread
Milestone
1.12.4

Comments

@mattdowle
Copy link
Member

mattdowle commented Feb 15, 2017 •
edited
Loading

For character columns, if uniqueN(column)/nrow < 0.2 then make the column a factor. Generalizing current binary argument to a scale between FALSE (0.0) and TRUE (1.0).
Request came up for onwards model build which switches based on character / factor type.
No change to default FALSE.
@mattdowle mattdowle added this to the v1.10.6 milestone Feb 15, 2017
@st-pasha st-pasha mentioned this issue Jul 6, 2017
Closed
@mattdowle mattdowle modified the milestones: v1.10.6, Candidate Nov 10, 2017
HughParsonage added a commit to HughParsonage/data.table that referenced this issue Jan 16, 2018
@HughParsonage
Closes Rdatatable#2025
a4b6c35
@HughParsonage HughParsonage mentioned this issue Jan 16, 2018
Merged
HughParsonage added a commit to HughParsonage/data.table that referenced this issue Jan 16, 2018
@HughParsonage
Update NEWS and documentation for Rdatatable#2025
ccdf57c
HughParsonage added a commit to HughParsonage/data.table that referenced this issue Jan 16, 2018
@HughParsonage
Merge pull request #3 from HughParsonage/colClasses-valid-type-2545
6c22aa8 
Update NEWS and documentation for Rdatatable#2025
@mattdowle mattdowle removed this from the Candidate milestone May 10, 2018
@mattdowle mattdowle added this to the 1.12.4 milestone May 1, 2019
@MichaelChirico
Copy link
Member

the closing PR is a bit large, @HughParsonage can you confirm this issue was closed at the R level? I seem to recall it was...

@HughParsonage
Copy link
Member

Yes:

data.table/R/fread.R

Line 322 in be6c1fc

if (is.double(stringsAsFactors)) { #2025

@MichaelChirico MichaelChirico mentioned this issue Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request fread
Projects
None yet
Milestone
1.12.4
Development

Successfully merging a pull request may close this issue.

Various colClasses enhancements HughParsonage/data.table
4 participants
@mattdowle @jangorecki @MichaelChirico @HughParsonage