Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of deprecated CLOENV with R_ClosureEnv if R >= 4.5.0 (closes #1360) #1361

Merged
merged 3 commits into from
Mar 12, 2025
Merged

Replace use of deprecated CLOENV with R_ClosureEnv if R >= 4.5.0 (closes #1360) #1361

merged 3 commits into from
Mar 12, 2025
+25 −10

Conversation

eddelbuettel
Copy link
Member

This addresses an issue raised by @bbolker in #1360: CLOENV is now flagged by R-devel.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

kevinushey
kevinushey approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel
Copy link
Member Author

As expected, no issues in reverse-depends check so proceding to merge.

@eddelbuettel eddelbuettel merged commit 34997ab into master Mar 12, 2025
@eddelbuettel eddelbuettel deleted the feature/replace_cloenv branch March 12, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinushey kevinushey kevinushey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddelbuettel @kevinushey