Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert remaining DATAPTR to DATAPTR_RO #1359

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Conversation

eddelbuettel
Copy link
Member

As CRAN checks nag about the one remaining DAtAPTR use, a quick change to DATAPTR_RO which should pass for all reasonable use cases. Running full reverse-depends checks now (which will take its usual time ... measured in days now) to determine if anybody out there "is naughty" instead of nice.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@kevinushey
Copy link
Contributor

LGTM!

@eddelbuettel
Copy link
Member Author

🤞

Rev deps looking good too so far, but it's only been a fraction...

@kevinushey
Copy link
Contributor

We probably need some way of eventually deprecating / removing this, but that feels like a "Later" kind of issue.

@eddelbuettel
Copy link
Member Author

With the _RO being blessed, do we really have to?

@eddelbuettel
Copy link
Member Author

No changes to worse or new issues. (A few packages added since last run had new depends, they will get re-tested in the next one I do for CLOENV (which is an 'empty' test as the condition will only for R 4.5.0 or later and we test with 4.4.*).

So merging.

@eddelbuettel eddelbuettel merged commit b8d393a into master Mar 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants