Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand libraries vignette with PACKAGE_types.h #1355

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Jan 25, 2025

This comes from a discussion over at RcppEigen which revealed that our trick of using PACKAGE_types.h to declare types known to RcppExports.cpp is not as well known.

So a brief reference was added to Rcpp-libraries vignette which is somewhat topical.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo below; otherwise, LGTM!

vignettes/rmd/Rcpp-libraries.Rmd Outdated Show resolved Hide resolved
@eddelbuettel eddelbuettel merged commit 7ecadc3 into master Jan 26, 2025
18 checks passed
@eddelbuettel eddelbuettel deleted the feature/expand_vignette branch January 26, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants