Make nesting work for newly added child observables #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose you create an
ObservStruct
and then decide to add more observable keys to it at some later point. Well, since all the nice magic only happens on initialization, that doesn't really work. For example, if you do something like:then
baz()
would return{ foo: "foo", bar: [Function: observable] }
rather than{ foo: "foo", bar: "bar" }
; andbaz.bar
would also remainundefined
rather than becoming a proper reference tobar
.That behavior was getting in my way -- I'm putting together a simple observable key-value store for individually observable models, to serve as a state container for my app which involves a lot of user-created instances of said models -- so I had a stab at fixing it. Let me know what you think?