Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly retrieve entity value #9864

Merged
merged 2 commits into from
Oct 14, 2021
Merged

properly retrieve entity value #9864

merged 2 commits into from
Oct 14, 2021

Conversation

wochinge
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from a team as a code owner October 13, 2021 16:25
@wochinge wochinge requested review from ka-bu, usc-m and a team and removed request for a team and ka-bu October 13, 2021 16:25
@wochinge wochinge mentioned this pull request Oct 13, 2021
Closed
usc-m
usc-m approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@usc-m usc-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wochinge wochinge enabled auto-merge October 14, 2021 07:29
@wochinge wochinge merged commit 11f2118 into 2.8.x Oct 14, 2021
@wochinge wochinge deleted the fix-wit-migration branch October 14, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usc-m usc-m usc-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wochinge @usc-m