Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows CI tests #9645

Merged
merged 4 commits into from
Sep 16, 2021
Merged

Windows CI tests #9645

merged 4 commits into from
Sep 16, 2021

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Sep 15, 2021 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@alwx
Copy link
Contributor Author

alwx commented Sep 15, 2021 •
edited
Loading

In fact, there are no modifications needed — all tests just run on Windows with Python 3.8 (see this run, for example: https://github.com/RasaHQ/rasa/runs/3609069395)

@alwx alwx requested a review from wochinge September 15, 2021 12:40
@alwx alwx marked this pull request as ready for review September 15, 2021 12:40
@alwx alwx requested a review from a team as a code owner September 15, 2021 12:40
@alwx alwx requested review from RASADSA and removed request for a team and RASADSA September 15, 2021 12:40
wochinge
wochinge approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🚀

@alwx alwx enabled auto-merge September 16, 2021 07:39
@alwx alwx merged commit 18dca85 into main Sep 16, 2021
@alwx alwx deleted the windows-ci-tests branch September 16, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

@RASADSA RASADSA Awaiting requested review from RASADSA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alwx @wochinge