Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return mypy issues #9054

Merged
merged 15 commits into from
Jul 13, 2021
Merged

fix return mypy issues #9054

merged 15 commits into from
Jul 13, 2021

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Jul 6, 2021

Proposed changes:

  • ...

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge changed the base branch from main to 8242-mypy_return_issues July 6, 2021 15:54
@wochinge wochinge mentioned this pull request Jul 6, 2021
Closed
2 tasks
@joejuzl joejuzl force-pushed the 8242-mypy_return_issues branch 2 times, most recently from ed70eec to 1ded5ef Compare July 12, 2021 13:49
@wochinge wochinge force-pushed the 8242-mypy_return_issues-tobias branch 3 times, most recently from 648fcbc to b63a55a Compare July 13, 2021 09:01
wochinge
wochinge commented Jul 13, 2021
View reviewed changes
rasa/shared/nlu/training_data/formats/rasa_yaml.py

Returns:
NLU training data examples prepared for writing to YAML.
"""
intents = []

for intent_name, examples in training_examples.items():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skipped renaming / fixing this as this would lead to far. But yes, it's bad.

@wochinge wochinge force-pushed the 8242-mypy_return_issues-tobias branch from b3a84e8 to 787cda9 Compare July 13, 2021 09:42
@wochinge wochinge requested a review from joejuzl July 13, 2021 09:55
@wochinge wochinge marked this pull request as ready for review July 13, 2021 09:55
@wochinge wochinge requested a review from a team as a code owner July 13, 2021 09:55
@wochinge wochinge requested review from a team and alopez and removed request for a team July 13, 2021 09:55
@wochinge wochinge removed request for a team and alopez July 13, 2021 09:56
@wochinge wochinge merged commit f72b9ed into 8242-mypy_return_issues Jul 13, 2021
@wochinge wochinge deleted the 8242-mypy_return_issues-tobias branch July 13, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joejuzl joejuzl Awaiting requested review from joejuzl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wochinge