RasaHQ · alwx · Sep 20, 2021 · Feb 26, 2021 · Feb 26, 2021 · Feb 26, 2021
diff --git a/CHANGELOG.mdx b/CHANGELOG.mdx
@@ -3924,3 +3924,4 @@ Regression: changes from `1.2.12` were missing from `1.4.0`, readded them
 
 * utterance templates defined in actions are checked for existence upon training a new agent, and a warning
   is thrown before training if one is missing
+* added authentication support for rabbitmq url which was missing before
@@ -6,6 +6,7 @@
 from asyncio import AbstractEventLoop
 from collections import deque
 from typing import Deque, Dict, Optional, Text, Union, Any, List, Tuple
+from urllib.parse import urlparse
 
 import aio_pika
 
@@ -168,7 +169,9 @@ async def _connect(self) -> aio_pika.RobustConnection:
         # The `url` parameter will take precedence over parameters like `login` or
         # `password`.
         if self.host.startswith("amqp"):
-            url = self.host
+
+            host_ob = urlparse(self.host)
+            url = f"{host_ob.scheme}://{self.username}:{self.password}@{host_ob.netloc}:{self.port}"
 
         ssl_options = _create_rabbitmq_ssl_options(self.host)
         logger.info("Connecting to RabbitMQ ...")
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3924,3 +3924,4 @@ Regression: changes from `1.2.12` were missing from `1.4.0`, readded them

		* utterance templates defined in actions are checked for existence upon training a new agent, and a warning
		is thrown before training if one is missing
		* added authentication support for rabbitmq url which was missing before
Copy link Contributor alwx Aug 4, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. We don't usually change old changelog entries — the new one needs to be added instead. This guide contains the detailed information about the process: https://github.com/RasaHQ/rasa/blob/main/changelog/README.md But to keep it short: could you please create a `8057.improvement.md` file inside a `changelog` directory with all the information about what was done in this PR instead of modifying `CHANGELOG.mdx`? Copy link Contributor Author nakshathru Aug 5, 2021 • edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. @alwx Sounds good!! removed change log entry and created new one as per your suggestion Copy link Contributor alwx Aug 16, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Awesome, thanks!