-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider confidence values in 'ensure_consistent_bilou_tagging' #6639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how troublesome to implement it, but is it possible to output original tags during rasa test
as well?
You mean the tags before they got updated? mmhh... not that easy, as the tags are converted into proper entities and I am not sure how you would add the "old" tags in there. |
Let's create an issue for it to discuss it. So that this PR is not blocked |
Could you please add the description of this substitution process to docs, please? |
Where should it go? We do not have a section for it as far as i know. |
hm, it seems that we don't have a place where we describe bilou tagging scheme. I think we should add it some where |
@erohmensing tagging you as a review as I added a section about BILOU tagging to the docs. As the information about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the part about BILOU tags looks good.
I wouldn't remove nlu-training-data.mdx
as part of this PR. To avoid confusion, let's do it in a separate PR
followed the suggestion of @Ghostvv and added the page about nlu training data again and just added the bilou section to that page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Applied all review comments, thanks for the comments! @erohmensing or @Ghostvv can someone please approve so that we can merge this PR? Thanks. |
oh no, just realised that we will not be able to merge as a lot of tests will all fail due to the convert issue |
Proposed changes:
The method
ensure_consistent_bilou_tagging
now also considers the confidence values of the predicted tagswhen updating the BIlOU tags.
closes #6039
Status (please check what you already did):
black
(please check Readme for instructions)