Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider confidence values in 'ensure_consistent_bilou_tagging' #6639

Merged
merged 23 commits into from
Sep 29, 2020

Conversation

tabergma
Copy link
Contributor

Proposed changes:
The method ensure_consistent_bilou_tagging now also considers the confidence values of the predicted tags
when updating the BIlOU tags.

closes #6039

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma requested a review from Ghostvv September 11, 2020 08:42
Copy link
Contributor

@Ghostvv Ghostvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how troublesome to implement it, but is it possible to output original tags during rasa test as well?

@tabergma
Copy link
Contributor Author

You mean the tags before they got updated? mmhh... not that easy, as the tags are converted into proper entities and I am not sure how you would add the "old" tags in there.

@Ghostvv
Copy link
Contributor

Ghostvv commented Sep 11, 2020

Let's create an issue for it to discuss it. So that this PR is not blocked

@tabergma
Copy link
Contributor Author

#6647

Ghostvv
Ghostvv previously approved these changes Sep 11, 2020
@Ghostvv
Copy link
Contributor

Ghostvv commented Sep 11, 2020

Could you please add the description of this substitution process to docs, please?

@tabergma
Copy link
Contributor Author

Where should it go? We do not have a section for it as far as i know.

@Ghostvv
Copy link
Contributor

Ghostvv commented Sep 11, 2020

hm, it seems that we don't have a place where we describe bilou tagging scheme. I think we should add it some where

@Ghostvv Ghostvv dismissed their stale review September 11, 2020 15:06

let's add docs as part of this PR

@tabergma
Copy link
Contributor Author

@erohmensing tagging you as a review as I added a section about BILOU tagging to the docs. As the information about NLU Training Data was already included in Training Data Format I removed it and kept just the entity related stuff. Let me know if that does not work and the section should be moved somewhere else.

@tabergma tabergma requested a review from Ghostvv September 22, 2020 12:38
@tabergma tabergma mentioned this pull request Sep 22, 2020
4 tasks
Copy link
Contributor

@Ghostvv Ghostvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the part about BILOU tags looks good.
I wouldn't remove nlu-training-data.mdx as part of this PR. To avoid confusion, let's do it in a separate PR

@tabergma
Copy link
Contributor Author

followed the suggestion of @Ghostvv and added the page about nlu training data again and just added the bilou section to that page

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tabergma and others added 7 commits September 28, 2020 11:48
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
@tabergma
Copy link
Contributor Author

Applied all review comments, thanks for the comments!

@erohmensing or @Ghostvv can someone please approve so that we can merge this PR? Thanks.

@erohmensing erohmensing self-requested a review September 28, 2020 09:58
@tabergma
Copy link
Contributor Author

oh no, just realised that we will not be able to merge as a lot of tests will all fail due to the convert issue

@rasabot rasabot merged commit 74bcb96 into master Sep 29, 2020
@rasabot rasabot deleted the ensure-consistent-bilou-tagging branch September 29, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'ensure_consistent_bilou_tagging' should consider confidence values
4 participants