Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/slack channel/proxy #6126

Merged
merged 19 commits into from
Jul 28, 2020
Merged

Feature/slack channel/proxy #6126

merged 19 commits into from
Jul 28, 2020

Conversation

iamtofr
Copy link
Contributor

@iamtofr iamtofr commented Jul 2, 2020 •
edited
Loading

Fixes #6123
Proposed changes:

  • adds proxy property to credentials.yml
  • make proxy optional
  • update docs and changelog

Status (please check what you already did):

  • [/] added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sara-tagger sara-tagger requested a review from amn41 July 2, 2020 12:00
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @amn41 will take a look at it as soon as possible ✨

@iamtofr iamtofr changed the title Fetaure/slack channel/proxy Feature/slack channel/proxy Jul 2, 2020
@iamtofr
Copy link
Contributor Author

iamtofr commented Jul 6, 2020

#6123

@iamtofr iamtofr changed the title Feature/slack channel/proxy Feature/slack channel/proxy #6123 Jul 10, 2020
@iamtofr iamtofr changed the title Feature/slack channel/proxy #6123 Feature/slack channel/proxy Jul 10, 2020
ricwo
ricwo suggested changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! The code looks great - just left a few comments. This will be good to go once they're addressed 👍

iamtofr and others added 5 commits July 28, 2020 10:03
@iamtofr @ricwo
Update changelog/6123.improvement.rst
19ce2fd 
Co-authored-by: ricwo <20581300+ricwo@users.noreply.github.com>
@iamtofr @ricwo
Update docs/user-guide/connectors/slack.rst
ff1033f 
Co-authored-by: ricwo <20581300+ricwo@users.noreply.github.com>
@iamtofr @ricwo
Update rasa/cli/initial_project/credentials.yml
dda47b8 
Co-authored-by: ricwo <20581300+ricwo@users.noreply.github.com>
@iamtofr
Merge branch 'master' into fetaure/slackChannel/proxy
bb97378
adds a few comments
b98c429
ricwo
ricwo approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@ricwo ricwo merged commit 8809c55 into RasaHQ:master Jul 28, 2020
@desmarchris desmarchris mentioned this pull request Jan 7, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo ricwo approved these changes

@amn41 amn41 Awaiting requested review from amn41

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slack proxy option support
4 participants
@iamtofr @CLAassistant @sara-tagger @ricwo