-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack Button Fix and Threaded Messaging #6020
Merged
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
c40ef48
button block debug
rgstephens f1a7689
threads in progress
rgstephens 78a8f38
Updated threading for non-text responses and added fixes for button p…
b-quachtran d5ea128
Removed comments
b-quachtran 284225b
Fixed bug when text value is empty
b-quachtran 33c1ae8
Removed comment
b-quachtran 0d29b3c
Reverted button text condition
b-quachtran be9f38f
Removed testing debug statements
b-quachtran f1023e1
Code cleanup
b-quachtran aa13d65
Initial doc update
b-quachtran 5db35fe
Code linting
b-quachtran 25ba94c
Updated changelog
b-quachtran 3db2435
Black formatting
b-quachtran 30f4f85
Type check update
b-quachtran 597dff4
Fix type test errors
b-quachtran 535565d
Update slack.py
b-quachtran 05dd45a
Update slack.py
b-quachtran 3bb7c08
Update slack.py
b-quachtran 233098c
Merge branch 'master' into slack-enhancements
b-quachtran 90d84fd
Update slack.py
b-quachtran 344ce53
Update slack.py
b-quachtran 554ef75
Initial test thread functions
b-quachtran a8450ce
Merge branch 'slack-enhancements' of https://github.com/RasaHQ/rasa i…
b-quachtran 40436ba
Added header check for request
b-quachtran 3d78a8a
Created test cases for threaded Slack messages
b-quachtran dacc08f
Removed old changelog
b-quachtran d1f8b35
Code linting
b-quachtran 289aa6a
Merge branch 'master' into slack-enhancements
b-quachtran b73d955
Update slack.py
b-quachtran 47c20a3
Added additional Slack connector test cases
b-quachtran 7dcaa94
Merge branch 'slack-enhancements' of https://github.com/RasaHQ/rasa i…
b-quachtran 7d75b61
Created changelog
b-quachtran d319832
Merge branch 'master' into slack-enhancements
b-quachtran dca2f45
Update rasa/core/channels/slack.py
b-quachtran b778ba1
Update rasa/core/channels/slack.py
b-quachtran ade06e7
Update rasa/core/channels/slack.py
b-quachtran 1c79ba1
Review changes
b-quachtran ae00cd5
Merge branch 'master' into slack-enhancements
b-quachtran c9814f7
Updated custom_json function call
b-quachtran ae7aadb
Merge branch 'slack-enhancements' of https://github.com/RasaHQ/rasa i…
b-quachtran 7b42a2e
Update rasa/core/channels/slack.py
b-quachtran 5c6b800
Renamed ts to thread_id, added comments, moved constant into channels…
b-quachtran 88f0efa
Update test_channels.py
b-quachtran 01c0d88
Fixed ts key
b-quachtran e0a1692
Merge branch 'slack-enhancements' of https://github.com/RasaHQ/rasa i…
b-quachtran 9921160
Updated slack tests
b-quachtran b4abe9a
Test bug fix
b-quachtran eeaf1ff
Merge branch 'master' into slack-enhancements
b-quachtran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
You can now enable threaded message responses from Rasa through the Slack connector. | ||
This option is enabled using an optional configuration in the credentials.yml file | ||
|
||
.. code-block:: none | ||
|
||
slack: | ||
slack_token: | ||
slack_channel: | ||
use_threads: True | ||
|
||
Button support has also been added in the Slack connector. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@b-quachtran This line confuses me - shouldn't it be
metadata.get("thread_id")
now? If I'm not mistaken, can you create a PR with a quick fix?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then we should probably also extend the tests to include a case that would have caught this (e.g. a test where we get a message event, post a reply to the same thread, and assert that everything went as expected).
If you have time, this could go into the PR with the fix, otherwise let's just create an issue to add such a test.