Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing output of story evaluation #5963

Merged
merged 15 commits into from
Jun 9, 2020
Merged

Improve testing output of story evaluation #5963

merged 15 commits into from
Jun 9, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented Jun 5, 2020

Proposed changes:
closes #5748

Add option to write down successful story predictions to disk.
Add option to disable writing down incorrect story predictions.
Write down summary report to disk.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma requested a review from federicotdn June 5, 2020 08:56
Copy link
Contributor

@federicotdn federicotdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! Thanks for adding all those types as well. I've added some comments.

@tabergma tabergma requested a review from federicotdn June 8, 2020 11:38
Copy link
Contributor

@federicotdn federicotdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@tabergma tabergma merged commit 2725bda into master Jun 9, 2020
@tabergma tabergma deleted the story-testing branch June 9, 2020 06:02
@rgstephens
Copy link
Contributor

Is this set to be included in 2.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize testing output
3 participants