Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible NLU pipeline #5863

Merged
merged 57 commits into from
Jun 5, 2020
Merged

Flexible NLU pipeline #5863

merged 57 commits into from
Jun 5, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented May 20, 2020 •
edited
Loading

Proposed changes:
closes #5510

You can set an alias for every featurizer in your pipeline. You can then specify on, for example, the DIETClassifier or the ResponseSelector what features from which featurizers should go in.
If you don't set the option featurizers all available features will be used. This is also the default behaviour.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

tabergma added 30 commits May 4, 2020 17:16
@tabergma
create Features class
d0c173b
@tabergma
Draft message.get_features
d0a22a8
@tabergma
fix get_sparse/dense_features
20bb3b5
@tabergma
padding lower dim features
9bd4e8b
@tabergma
update DIETClassifier
a9efca9
@tabergma
training works
313478d
@tabergma
prediction works
4b64f10
@tabergma
refactoring
c89d8af
@tabergma
Merge branch 'master' into nlu-configuration
b4f2a01
@tabergma
convert featurizer is independent from tokenizer
5a7c97f
@tabergma
set eager mode to False again
0bafdfd
@tabergma
naming
857f10f
@tabergma
naming
8775bab
@tabergma
check if additional ffn is needed
ca4a653
@tabergma
Merge branch 'master' into nlu-configuration
57280e6
@tabergma
fix concat bug
6f9685b
@tabergma
use sparse dense dim
062af61
@tabergma
remove convert tokenizer
707e1cc
@tabergma
remove not needed constants
05fda3f
@tabergma
start fixing tests
b14464c
@tabergma
use dense dim
096cb29
@tabergma
fix more tests
3f9df89
@tabergma
fix more tests
71c8c41
@tabergma
fix testing
892a122
@tabergma
Merge branch 'master' into nlu-configuration
c602b26
@tabergma
revert changes in classifiers
5154a85
@tabergma
update featurizers
4796b00
@tabergma
update tests
7f33431
@tabergma
clean up
ec7b9c4
@tabergma
fix tests
f2d630e
@tabergma tabergma requested review from Ghostvv and ricwo May 20, 2020 07:13
Ghostvv
Ghostvv reviewed May 20, 2020
View reviewed changes
docs/nlu/components.rst Outdated Show resolved Hide resolved
rasa/nlu/classifiers/diet_classifier.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/message.py Show resolved Hide resolved
@Ghostvv Ghostvv requested a review from evgeniiaraz May 25, 2020 08:47
ricwo
ricwo approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

changelog/5510.feature.rst Show resolved Hide resolved
data/configs_for_docs/config_featurizers.yml Outdated Show resolved Hide resolved
docs/nlu/choosing-a-pipeline.rst Outdated Show resolved Hide resolved
changelog/5510.feature.rst Outdated Show resolved Hide resolved
changelog/5510.feature.rst Outdated Show resolved Hide resolved
rasa/nlu/training_data/message.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/message.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/message.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/message.py Outdated Show resolved Hide resolved
tests/nlu/training_data/test_message.py Show resolved Hide resolved
@tabergma tabergma merged commit 815a9af into master Jun 5, 2020
@tabergma tabergma deleted the flexible-nlu-pipeline branch June 5, 2020 07:07
@tabergma tabergma mentioned this pull request Jun 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghostvv Ghostvv Ghostvv left review comments

@ricwo ricwo ricwo approved these changes

@evgeniiaraz evgeniiaraz Awaiting requested review from evgeniiaraz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make NLU configuration more flexible
3 participants
@tabergma @Ghostvv @ricwo