Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ambiguity_threshold to fallback actions page #5857

Merged
merged 7 commits into from
May 28, 2020
Merged

Added ambiguity_threshold to fallback actions page #5857

merged 7 commits into from
May 28, 2020

Conversation

Archish27
Copy link
Contributor

@Archish27 Archish27 commented May 19, 2020 •
edited by erohmensing
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link

CLAassistant commented May 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Archish27 Archish27 mentioned this pull request May 19, 2020
Closed
@sara-tagger sara-tagger requested a review from tttthomasssss May 20, 2020 09:22
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @tttthomasssss will take a look at it as soon as possible ✨

tttthomasssss
tttthomasssss suggested changes May 26, 2020
View reviewed changes
Copy link
Contributor

@tttthomasssss tttthomasssss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one little typo, should be [...] or if **the** highest ranked intent [...]. (w/o the asterisks obv.)

Otherwise LGTM - thanks very much for your effort 👍!

@Archish27 Archish27 force-pushed the fallback-actions-page branch from 20b9860 to 21c035d Compare May 26, 2020 10:49
@Archish27 Archish27 requested a review from tttthomasssss May 26, 2020 10:50
erohmensing
erohmensing reviewed May 28, 2020
View reviewed changes
Archish27 and others added 2 commits May 28, 2020 13:51
@Archish27 @erohmensing
Update changelog/4441.doc.rst
d0decc3 
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
@Archish27
Merge branch 'master' into fallback-actions-page
2fea066
@Archish27 Archish27 requested a review from erohmensing May 28, 2020 08:25
erohmensing
erohmensing approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you addressed @tttthomasssss 's comments as well 👍

@erohmensing erohmensing removed the request for review from tttthomasssss May 28, 2020 08:47
@Archish27 Archish27 requested a review from tttthomasssss May 28, 2020 09:40
tttthomasssss
tttthomasssss approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@tttthomasssss tttthomasssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks very much for your contribution!

@tttthomasssss tttthomasssss merged commit 4fe8f51 into RasaHQ:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tttthomasssss tttthomasssss tttthomasssss approved these changes

@erohmensing erohmensing erohmensing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ambiguity_threshold not documented in "Fallback actions" page
5 participants
@Archish27 @CLAassistant @sara-tagger @tttthomasssss @erohmensing