Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set roles/groups to 'O' #5797

Merged
merged 2 commits into from
May 12, 2020
Merged

Don't set roles/groups to 'O' #5797

merged 2 commits into from
May 12, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented May 11, 2020 •
edited
Loading

Proposed changes:
Fixes #5788

Don't set roles and groups to O (nothing found) when constructing entities from model predictions.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma requested a review from ricwo May 11, 2020 08:02
ricwo
ricwo approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tabergma tabergma merged commit 79cb399 into 1.10.x May 12, 2020
@tabergma tabergma deleted the empty-role-group branch May 12, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo ricwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabergma @ricwo