Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use concat_url to add "/parse" to duckling url safely #5790

Merged
merged 4 commits into from
May 11, 2020

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented May 7, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@erohmensing erohmensing requested a review from tabergma May 7, 2020 16:32
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@erohmensing erohmensing merged commit 2e1c0ff into 1.10.x May 11, 2020
@erohmensing erohmensing deleted the duckling-slash branch May 11, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants