Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort nlu/story files before training #5455

Merged
merged 3 commits into from
Mar 23, 2020
Merged

sort nlu/story files before training #5455

merged 3 commits into from
Mar 23, 2020

Conversation

akelad
Copy link
Contributor

@akelad akelad commented Mar 20, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@akelad akelad changed the base branch from master to 1.8.x March 20, 2020 10:46
@akelad akelad requested a review from wochinge March 20, 2020 10:50
@akelad
Copy link
Contributor Author

akelad commented Mar 20, 2020

hm ok tests are failing bc of types - is it fine that it's a list now or should i turn it into a set again?

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have to fix the types.
I'd change to list and _copy_files_to_new_dir to Iterable (then you can also remove the list in multi_project

I quickly checked rasa x and we have to change some types there, too, but nothing breaking 👍

rasa/data.py Show resolved Hide resolved
@akelad akelad merged commit b6c837d into 1.8.x Mar 23, 2020
@akelad akelad deleted the fix_training branch March 23, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants