-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConvertTokenizer, CLS token & features as sequence #4996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03d514f
to
8378370
Compare
Ghostvv
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! add a couple of minor comments
9a3187b
to
c5e3755
Compare
dakshvar22
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestions. Great work! 🚀
Co-Authored-By: Daksh Varshneya <d.varshneya@rasa.com>
Co-Authored-By: Daksh Varshneya <d.varshneya@rasa.com>
Co-Authored-By: Daksh Varshneya <d.varshneya@rasa.com>
c4830f8
to
189788b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
use_cls_token
from all tokenizers. Tokenizers add CLS token by default now.return_sequence
from featurizers. Featurizers return sequence by default. The feature vector of the CLS token contains the feature for the complete utterance.train
andprocess
of tokenizers inTokenizer
class. Subclasses just need to implementtokenize
.closes #4978
Status (please check what you already did):
black
(please check Readme for instructions)