Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors during training in ResponseSelector #4985

Merged
merged 13 commits into from
Dec 17, 2019
Merged

Fix errors during training in ResponseSelector #4985

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b99a127
set correct default values for response selector
tabergma Dec 17, 2019
d97e782
add changelog entry
tabergma Dec 17, 2019
7adc718
use correct label attribute in creating session data
tabergma Dec 17, 2019
6e0522f
use correct label attribute for label data
tabergma Dec 17, 2019
e6e9e6e
filter examples correctly
dakshvar22 Dec 17, 2019
7d081f9
Check if label id dict is present
tabergma Dec 17, 2019
050b90d
Update changelog
tabergma Dec 17, 2019
73a2019
rename intent_features to label_features
tabergma Dec 17, 2019
9d4a822
Merge branch 'master' into bug-fix-response-selector
tabergma Dec 17, 2019
736645f
fix typo in featurizer.py
tabergma Dec 17, 2019
c7c3881
added a test for response selector training
dakshvar22 Dec 17, 2019
5bec958
fix incorrect key value
tabergma Dec 17, 2019
b5103ff
remove unused variable
tabergma Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/4985.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Set correct default value for ``dense_dim`` in ``ResponseSelector``.
2 changes: 1 addition & 1 deletion rasa/nlu/selectors/embedding_response_selector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class ResponseSelector(EmbeddingIntentClassifier):
"random_seed": None,
# embedding parameters
# default dense dimension used if no dense features are present
"dense_dim": 512,
"dense_dim": {"text": 512, "intent": 20},
# dimension size of embedding vectors
"embed_dim": 20,
# the type of the similarity
Expand Down