Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mypy override check and fix errors #10965

Merged
merged 20 commits into from
Mar 10, 2022
Merged

Enable mypy override check and fix errors #10965

merged 20 commits into from
Mar 10, 2022

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Mar 4, 2022

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita requested a review from m-vdb March 4, 2022 15:01
@ancalita ancalita marked this pull request as ready for review March 4, 2022 15:01
@ancalita ancalita requested a review from a team March 4, 2022 15:01
@ancalita ancalita requested a review from a team as a code owner March 4, 2022 15:01
@ancalita ancalita requested review from kedz and joejuzl and removed request for a team and kedz March 4, 2022 15:01
m-vdb
m-vdb requested changes Mar 7, 2022
View reviewed changes
rasa/core/brokers/file.py Outdated Show resolved Hide resolved
rasa/core/channels/socketio.py Show resolved Hide resolved
rasa/core/featurizers/tracker_featurizers.py Outdated Show resolved Hide resolved
rasa/core/policies/ted_policy.py Outdated Show resolved Hide resolved
rasa/core/tracker_store.py Show resolved Hide resolved
rasa/shared/core/generator.py Outdated Show resolved Hide resolved
rasa/shared/core/trackers.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/dialogflow.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/rasa_yaml.py Show resolved Hide resolved
rasa/utils/tensorflow/layers.py Show resolved Hide resolved
@ancalita ancalita removed the request for review from joejuzl March 8, 2022 14:24
@ancalita ancalita requested a review from m-vdb March 9, 2022 10:52
m-vdb
m-vdb reviewed Mar 9, 2022
View reviewed changes
rasa/core/tracker_store.py Show resolved Hide resolved
rasa/core/tracker_store.py Show resolved Hide resolved
rasa/core/tracker_store.py Show resolved Hide resolved
m-vdb
m-vdb reviewed Mar 9, 2022
View reviewed changes
rasa/shared/core/generator.py Outdated Show resolved Hide resolved
m-vdb
m-vdb reviewed Mar 9, 2022
View reviewed changes
rasa/shared/core/generator.py Outdated Show resolved Hide resolved
ancalita
ancalita commented Mar 9, 2022
View reviewed changes
rasa/core/tracker_store.py Outdated Show resolved Hide resolved
@ancalita ancalita requested a review from m-vdb March 9, 2022 16:35
m-vdb
m-vdb approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments still to address, but I'll approve as we're really close. Great job 🎉

rasa/shared/core/events.py Outdated Show resolved Hide resolved
rasa/shared/core/generator.py Outdated Show resolved Hide resolved
@ancalita ancalita enabled auto-merge (squash) March 10, 2022 12:53
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://10965--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@ancalita ancalita merged commit 291f6c6 into main Mar 10, 2022
@ancalita ancalita deleted the 9097/mypy-override branch March 10, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vdb m-vdb m-vdb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable mypy override error code
2 participants
@ancalita @m-vdb