Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10823 update slack installation doc #10940

Merged
merged 5 commits into from
Feb 24, 2022
Merged

10823 update slack installation doc #10940

merged 5 commits into from
Feb 24, 2022

Conversation

sanchariGr
Copy link
Collaborator

Proposed changes:

  • As a fix for this Issue, there is a small update that was needed to the docs.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link

CLAassistant commented Feb 23, 2022

CLA assistant check
All committers have signed the CLA.

@sanchariGr sanchariGr requested a review from ancalita February 23, 2022 15:28
@ancalita ancalita requested a review from indam23 February 23, 2022 15:32
@ancalita ancalita linked an issue Feb 23, 2022 that may be closed by this pull request
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🙌🏼 Could you also add a doc changelog entry, guidelines are here: https://github.com/RasaHQ/rasa/blob/main/changelog/README.md

@sanchariGr
Copy link
Collaborator Author

Looks great 🙌🏼 Could you also add a doc changelog entry, guidelines are here: https://github.com/RasaHQ/rasa/blob/main/changelog/README.md

sorry missed that, on it 👍

Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the issue, do we need to add more permissions to the end of the section too?

@sanchariGr
Copy link
Collaborator Author

From the issue, do we need to add more permissions to the end of the section too?

@melindaloubser1 I tried both with and without the added permissions mentioned in the issue and it worked both times so i believe whatever was causing this was fixed by slack themselves, and so we dont need to add any other permissions.

sanchariGr and others added 2 commits February 24, 2022 09:10
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
@sanchariGr sanchariGr merged commit 3d5fb39 into 3.0.x Feb 24, 2022
@sanchariGr sanchariGr deleted the update-doc branch February 24, 2022 12:39
@m-vdb
Copy link
Collaborator

m-vdb commented Feb 25, 2022

woot woot first PR on Open Source @sanchariGr 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack Documentation/API seems out of date
5 participants