-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10823 update slack installation doc #10940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🙌🏼 Could you also add a doc
changelog entry, guidelines are here: https://github.com/RasaHQ/rasa/blob/main/changelog/README.md
sorry missed that, on it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the issue, do we need to add more permissions to the end of the section too?
@melindaloubser1 I tried both with and without the added permissions mentioned in the issue and it worked both times so i believe whatever was causing this was fixed by slack themselves, and so we dont need to add any other permissions. |
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
woot woot first PR on Open Source @sanchariGr 🎉 |
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)