Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port PR 10773 #10859

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Port PR 10773 #10859

merged 3 commits into from
Feb 11, 2022

Conversation

JEM-Mosig
Copy link

@JEM-Mosig JEM-Mosig commented Feb 10, 2022 •
edited
Loading

Proposed changes:

  • Same as here but ported to 3.0.x

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@JEM-Mosig JEM-Mosig requested review from tayfun, tttthomasssss, rctatman and a team February 10, 2022 17:50
@JEM-Mosig JEM-Mosig requested a review from a team as a code owner February 10, 2022 17:50
@JEM-Mosig JEM-Mosig changed the base branch from main to 3.0.x February 10, 2022 17:53
@JEM-Mosig JEM-Mosig removed the request for review from rctatman February 10, 2022 17:56
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://10859--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@JEM-Mosig JEM-Mosig removed request for tttthomasssss and a team February 10, 2022 18:06
@raoulvm raoulvm mentioned this pull request Feb 11, 2022
Closed
4 tasks
@JEM-Mosig JEM-Mosig merged commit 47b4770 into 3.0.x Feb 11, 2022
@JEM-Mosig JEM-Mosig deleted the multientities-3.0.x branch February 11, 2022 10:51
@JEM-Mosig JEM-Mosig restored the multientities-3.0.x branch February 11, 2022 10:51
@JEM-Mosig JEM-Mosig deleted the multientities-3.0.x branch February 11, 2022 10:54
@wochinge
Copy link
Contributor

@JEM-Mosig Isn't this a new feature? This in my opinion breaks semantic versioning

@JEM-Mosig
Copy link
Author

@wochinge This is a bugfix ported from 2.8.x. (Now i realize I should have changed the changelog name - sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tayfun tayfun tayfun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JEM-Mosig @wochinge @tayfun