Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration guide pointers for removed policies, tokenizers, and featurizers. #10171

Merged
merged 15 commits into from
Nov 16, 2021

Conversation

kedz
Copy link
Contributor

@kedz kedz commented Nov 10, 2021

Closes #9186

Proposed changes:

  • Adds pointers in 2x -> 3x migration docs to previous migration guides/guidance for
    • FormPolicy
    • MappingPolicy
    • FallbackPolicy
    • TwoStageFallbackPolicy
    • SklearnPolicy
    • ConveRTTokenizer
    • LanguageModelTokenizer
    • HFTransformersNLP

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@kedz kedz requested a review from indam23 November 10, 2021 22:15
@kedz kedz self-assigned this Nov 10, 2021
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
@kedz kedz requested a review from indam23 November 12, 2021 16:01
@indam23
Copy link
Contributor

indam23 commented Nov 12, 2021

Could you add featurize to the typo CI ignore list? Don't know why it's not there yet 😅

docs/docs/migration-guide.mdx Outdated Show resolved Hide resolved
docs/docs/migration-guide.mdx Outdated Show resolved Hide resolved
- `TwoStageFallbackPolicy` [migration guide](#manually-migrating-from-the-two-stage-fallback-policy)
- `MappingPolicy` [migration guide](#manually-migrating-from-the-mapping-policy)
- `FormPolicy` [migration guide](#forms)
- `SklearnPolicy` should be replaced with [TEDPolicy](/policies#ted-policy)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any indication of which settings to use when migrating? Even an entry to the changelog would help since there is no other info on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are referring to the SklearnPolicy specifically or all of the above policies?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sklearn specifically, my bad

Copy link
Contributor Author

@kedz kedz Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melindaloubser1 I can't find anything on SklearnPolicy other than this changelog entry (see #6658). The issue linked in the change log entry doesn't say anything about why or how it should be replaced.

I think the SklearnPolicy can take arbitrary sklearn models as an argument so it will be hard to give very specific guidance.

How does the following strike you:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, in that case yes sounds good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

docs/docs/migration-guide.mdx Outdated Show resolved Hide resolved
Chris Kedzie and others added 9 commits November 12, 2021 14:00
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
@kedz kedz requested a review from indam23 November 16, 2021 01:56
Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@indam23 indam23 merged commit 1d5ccbd into main Nov 16, 2021
@indam23 indam23 deleted the 9186.migration-guides branch November 16, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a migration guide for moving config from 2.8 to 3.0.
2 participants