-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration guide pointers for removed policies, tokenizers, and featurizers. #10171
Conversation
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
Could you add |
docs/docs/migration-guide.mdx
Outdated
- `TwoStageFallbackPolicy` [migration guide](#manually-migrating-from-the-two-stage-fallback-policy) | ||
- `MappingPolicy` [migration guide](#manually-migrating-from-the-mapping-policy) | ||
- `FormPolicy` [migration guide](#forms) | ||
- `SklearnPolicy` should be replaced with [TEDPolicy](/policies#ted-policy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any indication of which settings to use when migrating? Even an entry to the changelog would help since there is no other info on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are referring to the SklearnPolicy specifically or all of the above policies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sklearn specifically, my bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melindaloubser1 I can't find anything on SklearnPolicy other than this changelog entry (see #6658). The issue linked in the change log entry doesn't say anything about why or how it should be replaced.
I think the SklearnPolicy can take arbitrary sklearn models as an argument so it will be hard to give very specific guidance.
How does the following strike you:
SklearnPolicy
should be replaced with TEDPolicy. We recommend the default TEDPolicy config as a starting point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, in that case yes sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
… 'Rasa 3.0' to match the rest of docs.
…into 9186.migration-guides
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closes #9186
Proposed changes:
FormPolicy
MappingPolicy
FallbackPolicy
TwoStageFallbackPolicy
SklearnPolicy
ConveRTTokenizer
LanguageModelTokenizer
HFTransformersNLP
Status (please check what you already did):
black
(please check Readme for instructions)