Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrades 231122 #899

Merged
merged 9 commits into from
Dec 1, 2022
Merged

Dependency upgrades 231122 #899

merged 9 commits into from
Dec 1, 2022

Conversation

znat
Copy link
Contributor

@znat znat commented Nov 23, 2022

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

dependabot bot and others added 5 commits November 23, 2022 22:25
Bumps [prompt-toolkit](https://github.com/prompt-toolkit/python-prompt-toolkit) from 3.0.28 to 3.0.33.
- [Release notes](https://github.com/prompt-toolkit/python-prompt-toolkit/releases)
- [Changelog](https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/CHANGELOG)
- [Commits](prompt-toolkit/python-prompt-toolkit@3.0.28...3.0.33)

---
updated-dependencies:
- dependency-name: prompt-toolkit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump mypy from 0.971 to 0.991

Bumps [mypy](https://github.com/python/mypy) from 0.971 to 0.991.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.971...v0.991)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix mypy issue

* fix trainling blank space

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: znat <nathan.zylbersztejn@gmail.com>
Bumps [black](https://github.com/psf/black) from 22.8.0 to 22.10.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@22.8.0...22.10.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Znat <nathan.zylbersztejn@gmail.com>
Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 3.0.0 to 4.0.0.
- [Release notes](https://github.com/pytest-dev/pytest-cov/releases)
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v3.0.0...v4.0.0)

---
updated-dependencies:
- dependency-name: pytest-cov
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Znat <nathan.zylbersztejn@gmail.com>
@znat znat marked this pull request as draft November 23, 2022 21:33
@znat znat marked this pull request as ready for review November 24, 2022 09:29
@znat znat requested review from a team, tmbo and ancalita and removed request for a team and tmbo November 28, 2022 08:39
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we need to synch dependencies to the ones used by rasa too, I advise using this rasa-sdk branch and opening a PR on rasa side to check the prompt-toolkit update first.

pyproject.toml Outdated Show resolved Hide resolved
Comment on lines +75 to +86
pytest-cov = "^4.0.0"
coveralls = "^3.0.1"
pytest = "^7.1.3"
black = "22.8.0"
black = "22.10.0"
flake8 = "^5.0.4"
flake8-docstrings = "^1.5.0"
questionary = ">=1.5.1,<1.11.0"
towncrier = "^22.8.0"
toml = "^0.10.0"
pep440-version-utils = "^0.3.0"
semantic_version = "^2.8.5"
mypy = "^0.971"
mypy = "^0.991"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check if any pre-commit hook needs updating too.

Optional: Would be great if these updates also had the corresponding updates in rasa.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it is one more argument for bringing the sdk into rasa. Would prefer not to touch the rasa pr for now.

@znat znat merged commit 6ffc3a7 into main Dec 1, 2022
@znat znat deleted the dependency-upgrades-231122 branch December 1, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants