-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for application emojis #9891
Conversation
Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com>
Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay.
I think this is still technically a breaking change on the Emoji.guild
front because it'll do get_guild(0)
which will return None
. I suppose it can be okay to change the typing from Guild
to Optional[Guild]
as it is in the type hints in this extraordinary case.
…ature/app-emojis
Co-Authored-By: Danny <1695103+Rapptz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Summary
Docs PR: discord/discord-api-docs#7010
Bikeshedding discussion: https://canary.discord.com/channels/336642139381301249/1263586512998764604
Checklist