Revert "Set socket family of connector to AF_INET" #9870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-ni
force-pushed
the
master
branch
2 times, most recently
from
842f216
to
035e26b
Compare
This change was made since Discord doesn't support IPv6, and there were concerns about clients with DNS64 enabled without NAT64. However, this breaks hosts who don't have v4 connectivity and are _actually_ running NAT64. Having DNS64 without NAT64 is really an issue on the client's end. It would break far more than just discord.py, so I don't think we should be concerned about those cases.
|
I'm not a fan of this solution. This should probably be a |
|
Users can (Actually, this appears to have been removed, see now linked PR) pass in a connector already, having this be set to AF_INET by default causes the error in the more complex networking case to at least make sense, the error users would get without this in the failing case was not useful, see error from the original issue, maybe this should just be solved with additional documentation that if you have NAT64 without ipv4 you need to also have DNS64 and pass in your own connector. |
mikeshardmind
added a commit
to mikeshardmind/discord.py
that referenced
this pull request
Aug 5, 2024
This provides paths for users to handle two entirely seperate issues - Alternative fix for Rapptz#9870 - Allows handling of windows sslcontext issues without a global truststore.inject_into_ssl() use
mikeshardmind
added a commit
to mikeshardmind/discord.py
that referenced
this pull request
Aug 5, 2024
This provides paths for users to handle two entirely seperate issues - Alternative fix for Rapptz#9870 - Allows handling of windows sslcontext issues without a global truststore.inject_into_ssl() use
mikeshardmind
added a commit
to mikeshardmind/discord.py
that referenced
this pull request
Aug 5, 2024
This provides paths for users to handle two entirely seperate issues - Alternative fix for Rapptz#9870 - Allows handling of windows sslcontext issues without a global truststore.inject_into_ssl() use
6 tasks
mikeshardmind
added a commit
to mikeshardmind/discord.py
that referenced
this pull request
Aug 5, 2024
This provides paths for users to handle two entirely seperate issues - Alternative fix for Rapptz#9870 - Allows handling of windows sslcontext issues without a global truststore.inject_into_ssl() use
Rapptz
pushed a commit
that referenced
this pull request
Aug 28, 2024
This provides paths for users to handle two entirely seperate issues - Alternative fix for #9870 - Allows handling of windows sslcontext issues without a global truststore.inject_into_ssl() use
|
I've given this some more thought and I'm just going to go ahead and allow it. |
parelite
added a commit
to parelite/discord.py
that referenced
this pull request
Aug 29, 2024
* Fix documentation for abc.GuildChannel.move to be more clear * Fix Polls limiting duration at 7 days * Fix _get_command_error improperly handling some error messages * Fix introduced potential TypeError with _get_command_error * Re-add client connector param This provides paths for users to handle two entirely seperate issues - Alternative fix for Rapptz#9870 - Allows handling of windows sslcontext issues without a global truststore.inject_into_ssl() use * Fix Poll.duration rounding error * Add support for getting the attachment's title * Fix default_avatar for team user and webhook * [docs] Remove pack_id attribute from Sticker [docs] Remove unnecessary pack_id * Fix url for GIF StickerItem * [docs] correct hyperlink to discord docs * [docs] Fix typehint for Embed.set_(image,thumbnail) * Remove stale documentation in Embed.set_thumbnail * Add Guild.fetch_role * Add approximate_user_install_count to AppInfo * Revert "Set socket family of connector to AF_INET" This change was made since Discord doesn't support IPv6, and there were concerns about clients with DNS64 enabled without NAT64. However, this breaks hosts who don't have v4 connectivity and are _actually_ running NAT64. Having DNS64 without NAT64 is really an issue on the client's end. It would break far more than just discord.py, so I don't think we should be concerned about those cases. * Add support for get sticker pack * Fix stacklevel for Message.interaction deprecation warning * Use fallback audioop package for Python v3.13 or higher Fix Rapptz#9477 * Add DummyCookieJar to client owned ClientSession * Add missing guild incident fields Co-authored-by: owocado <24418520+owocado@users.noreply.github.com> Co-authored-by: Danny <1695103+Rapptz@users.noreply.github.com> * Add support Member.fetch_voice * Add support for application emojis Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com> Co-authored-by: Danny <1695103+Rapptz@users.noreply.github.com> * Add a warning if interaction endpoint URL is set on login * Remove aiodns from being used on Windows --------- Co-authored-by: Rapptz <rapptz@gmail.com> Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com> Co-authored-by: Pipythonmc <47196755+pythonmcpi@users.noreply.github.com> Co-authored-by: Michael H <michael@michaelhall.tech> Co-authored-by: ambdroid <61042504+ambdroid@users.noreply.github.com> Co-authored-by: Soheab <33902984+Soheab@users.noreply.github.com> Co-authored-by: owocado <24418520+owocado@users.noreply.github.com> Co-authored-by: Andrin <65789180+Puncher1@users.noreply.github.com> Co-authored-by: Gaurav <raogaurav7007@gmail.com> Co-authored-by: fretgfr <51489753+fretgfr@users.noreply.github.com> Co-authored-by: lmaotrigine <57328245+lmaotrigine@users.noreply.github.com> Co-authored-by: Alex Nørgaard <Umbra@AbstractUmbra.dev> Co-authored-by: Oliver Ni <oliver.ni@gmail.com> Co-authored-by: Jakub Kuczys <me@jacken.men> Co-authored-by: Deep Jain <deepsjain123@gmail.com> Co-authored-by: Danny <1695103+Rapptz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was made since Discord doesn't support IPv6, and there were concerns about clients with DNS64 enabled without NAT64.
However, this breaks hosts who don't have v4 connectivity and are actually running NAT64 (me!)
Having DNS64 without NAT64 is really an issue on the client's end. It would break far more than just discord.py, so I don't think we should be concerned about those cases. I'm proposing this change be reverted.