-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy variable #9739
base: master
Are you sure you want to change the base?
Add proxy variable #9739
Conversation
Add the use of the proxy variable to the from_url function of the webhook class. During use, I found that the from_url function did not provide a proxy parameter to pass in. My area requires a proxy to access discord, so I added this parameter.
If you were to ask me, this isn't needed. I would wonder why even support proxies for webhooks? |
The reason for this is because you can set the proxies on the |
|
Needing a proxy is also a helpless move. Our country has blocked the website discord.com. |
Actually it seems you're right, I forgot this change happened to aiohttp a while back. This PR is insufficient though. It needs to support |
Added `proxy_auth` variable
I just added |
This is still missing documentation, and most likely needs to run black. |
Add description
Summary
Add the use of the proxy variable to the from_url function of the webhook class.
During use, I found that the from_url function did not provide a proxy parameter to pass in. My area requires a proxy to access discord, so I added this parameter.
Checklist