chore/get-external-ip-for-svc

[mosheavni]

perhaps there are other things that give this field the value but for my clusters, all I could find is status.loadBalancer.ingress[1].hostname

[Ramilito]

This is how the ingresses work, could it be the same?

local function get_address(row)
  local addresses = {}
  if row.status and row.status.loadBalancer and row.status.loadBalancer.ingress then
    for _, ingress in ipairs(row.status.loadBalancer.ingress) do
      if ingress.hostname then
        table.insert(addresses, ingress.hostname)
      elseif ingress.ip then
        table.insert(addresses, ingress.ip)
      end
    end
  end

  return table.concat(addresses, ", ")
end

[mosheavni]

This is how the ingresses work, could it be the same?

local function get_address(row)
  local addresses = {}
  if row.status and row.status.loadBalancer and row.status.loadBalancer.ingress then
    for _, ingress in ipairs(row.status.loadBalancer.ingress) do
      if ingress.hostname then
        table.insert(addresses, ingress.hostname)
      elseif ingress.ip then
        table.insert(addresses, ingress.ip)
      end
    end
  end

  return table.concat(addresses, ", ")
end

I'm not familiar with a case where a kind: Service can have multiple addresses but maybe I'm wrong

[Ramilito]

Tbh I'm not sure I nailed it in the ingresses resource either but took a look at k9s implementation and it looks like this:

From: https://github.com/derailed/k9s/blob/2492402ba3311ab6618f58d692ad15518c54cac6/internal/render/svc.go#L83

func getSvcExtIPS(svc *v1.Service) []string {
	results := []string{}

	switch svc.Spec.Type {
	case v1.ServiceTypeClusterIP:
		fallthrough
	case v1.ServiceTypeNodePort:
		return svc.Spec.ExternalIPs
	case v1.ServiceTypeLoadBalancer:
		lbIps := lbIngressIP(svc.Status.LoadBalancer)
		if len(svc.Spec.ExternalIPs) > 0 {
			if len(lbIps) > 0 {
				results = append(results, lbIps)
			}
			return append(results, svc.Spec.ExternalIPs...)
		}
		if len(lbIps) > 0 {
			results = append(results, lbIps)
		}
	case v1.ServiceTypeExternalName:
		results = append(results, svc.Spec.ExternalName)
	}

	return results
}