-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refresh float #322
feat: refresh float #322
Conversation
lua/kubectl/views/pods/init.lua
Outdated
ft = "k8s_desc", | ||
url = { "describe", "pod", name, "-n", ns }, | ||
syntax = "yaml", | ||
} | ||
|
||
if not name or not ns then | ||
def.url = nil | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we check if def.url is null to determine if this is a refresh, we should do this some other way, perhaps a parameter instead
found a little issue: when i first describe a pod, then quit the float, then describe a different pod, I see the last output. I have to close it again and re-describe it in order to see the right pod description. |
oh i was wrong, it was just loading but now it didn't display the "Loading..." when it actually did make sense to display it for every new describe |
you scared me there with the first comment 😅! I'll do some small beauty fixes to the code and then merge it hmm...I'm actually seeing what you described now |
@mosheavni The issue you mentioned should be fixed now, if we find any more lets open new pr's since this one is getting too big now |
Fixes #228
This is working as we want it I believe, do you want to verify @mosheavni?