chore/ingress-additions #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramilito
reviewed
Sep 19, 2024
ftplugin/k8s_ingresses.lua
Outdated
| @@ -13,6 +14,58 @@ local function set_keymap(bufnr) | |||
| overview_view.View() | |||
| end, | |||
| }) | |||
| api.nvim_buf_set_keymap(bufnr, "n", "gx", "", { | |||
There was a problem hiding this comment.
We need to add a plug function like this:
api.nvim_buf_set_keymap(bufnr, "n", "<Plug>(kubectl.browse)", "", {
|
Tell me when you feel ready to merge! |
|
the keymap doesn't appear on hints. mind stepping in here? |
Ramilito
reviewed
Sep 19, 2024
| @@ -5,6 +5,9 @@ local M = { | |||
| display_name = "Ingresses", | |||
| ft = "k8s_ingresses", | |||
| url = { "{{BASE}}/apis/networking.k8s.io/v1/{{NAMESPACE}}ingresses?pretty=false" }, | |||
| hints = { | |||
| { key = "<Plug>(kubectl.browse)", desc = "browse", long_desc = "Open host in browser" }, | |||
There was a problem hiding this comment.
and also add a hint here ☝️ (did an edit on the file since I couldn't comment without any changes)
Ramilito
reviewed
Sep 19, 2024
| local ingresses_view = require("kubectl.views.ingresses") | ||
| local loop = require("kubectl.utils.loop") | ||
| local overview_view = require("kubectl.views.overview") | ||
| local mappings = require("kubectl.mappings") | ||
|
|
||
| mappings.map_if_plug_not_set("n", "gx", "<Plug>(kubectl.browse)") |
There was a problem hiding this comment.
And then the actual mapping here ☝️
I did some ninja commits, but haven't verified that they actually work |
any idea why?
|
|
oh this stupid |
|
ready! |
|
Awesome idea about the browse to host btw 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix nil on
hostsfix ingress class, from annotation or from class property
open an ingress link in the browser