Ensure the server state is consistent whenever snapshot is called #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Ralith
approved these changes
Aug 11, 2024
Before this commit, if snapshot was called before the server ran its first step, there would be some unpopulated nodes in the graph, resulting in such nodes being transmitted to the client twice, once during the call to snapshot, and once as an accumulated change when calling step
patowen
force-pushed
the
first-step-consistency
branch
from
728a328 to
f58f39a
Compare
Ralith
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, if
snapshotwas called before the server ran its first step, there would be some unpopulated nodes in the graph, resulting in such nodes being transmitted to the client twice, once during the call tosnapshot, and once as an accumulated change when callingstep.This PR ensures that such an inconsistent state no longer occurs.