-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ci target for Makefile to reproduce github CI actions & artifacts #1769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞🏼 the comments make sense
Sure! Since this change in At first I wondered why the script scans all the files in the directory instead of reduce scanning to a pattern since the script have knowledge about model including multilang status (the first argument for json output file name) but:
|
…me argument processing / code review
…ame pattern processing / code review
…sion for output file
Oh, wait... since we change this script & a bit of its logic anyway, I think I have just one more little idea for tiny improvement here... |
…before looping through them to get the same lang order on every generation in every json output file
Done & tested: I made a full local build using |
What kind of change does this PR introduce?
Implement
ci
target forMakefile
to reproduce github CI actions & artifacts.What is the current behavior?
There is no fast & easy way to reproduce github CI jobs locally, for testing & debugging purposes or for preparing local zips with builds in bulk.
What is the new behavior (if this is a feature change)?
By running one
make ci
command, the produced binaries will be collected and packed into zips inside localBUILDS/CI
directory with the same content as downloadable zips fromActions
tab on github has.Other information:
Unfortunately, that's not "reproducible builds" per se, but nevertheless it's useful to have the same pipeline locally to exclude the factor of build environment in the case of some problem.
P.S. After a bit of puzzling myself how to take into consideration all the variations with names & lang options related to metadata json generating/parsing inside of
Makefile
, I just took some liberty to tweak a bitmetadata.py
instead. ;)