Remove 0.5 ohm increase to resistance #1728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, IronOS increases the tip resistance by 0.5 ohms for the purposes of USB-PD negotiation. On the Pinecil V2, this can cause issues with power supplies that only supply 60W, such as the Framework 60W supply. At 6.2 ohms, 20V will produce 3.2A, but at 6.7 ohms it will produce 2.985 ohms. This 0.5 ohms increase will cause the V2 to negotiate 20V, draw more than 3A, and trip the overcurrent protection, causing it to reboot. Removing this increase will therefore cause it to fall back to the next highest voltage it can achieve.
What kind of change does this PR introduce?
What is the current behavior?
On devices such as the Framework charger, attempting to operate the iron at 20V will cause it to reboot. This is not a device-specific issue, as other chargers do not cause this reboot to occur.
What is the new behavior (if this is a feature change)?
Reducing the voltage limit to 15V does fix the issue, but this is obviously a problematic solution given that it cuts off higher voltages and power levels. Removing the increase to tip resistance allows the iron to negotiate higher voltages when they are offered while not tripping overcurrent protection.
Other information: