Save settings on change only / All builds OK (#1699)

[ia]

Full description is provided here. With big help from Ralim, use of extra variable currentSettings has been removed. But I had to rearrange headers' content a bit.

As I mentioned before source tree of v2.21 release branch has been fully stuffed for TS80P with features. However when I applied changes to dev, I discovered some room for modifications - I did manage to get all builds successfully (S60 included). Full log here.

Is it good enough to merge? Do I have change something? Can't wait any feedback. Thanks.

[Ralim]

Heya,

Super glad the memcmp call worked for this.
Just wanted to confirm what devices you have tested this on (if any).
Mostly want to triple check PinecilV2, fairly sure the flash is remapped to 0x0 as per normal but will test if you haven't :).

But yep looks great to me.

[Ralim]

Looks mint to me, just want to check testing.

[ia]

Sorry for a delayed response, just wanted to check & double-check some stuff. Here is the thing. I have only one unit of supported hardware which is TS80P. And I'm not sure of how stable dev branch is (is it?). So what I could and did test on my side:

• all builds with this patch on dev branch for every supported unit per every language: successfully
• model=TS80P firmware-EN build (with this patch on v2.21 tagged source tree) has been tested physically on my TS80P unit: successfully

I may be not aware of some very tricky low level memory management nuances on MCUs. But as far as I understand since flash_read_buffer implementations read settings page through memcpy from memory address directly, and it works, then using the same approach for memcmp should work as well... right? 😅

[Ralim]

dev branch should be stable. Generally only bugs expected there are non-critical things like an odd glitch here or there.

Thanks for the info, tested this locally and all seems good so going to merge it in.
There shouldn't be any magic low level magic for memory maps on these devices. But I prefer to be cautious till I check it out, but your call on the reading proves how much I've forgotten and yep that does indeed confirm we can do this.