Skip to content

Commit

Permalink
Auto merge of #122095 - lukas-code:windows-shutdown-test, r=ChrisDenton
Browse files Browse the repository at this point in the history
fix `close_read_wakes_up` test

On windows, `shutdown` does not interrupt `read`, even though we document that it does (see rust-lang/rust#121594).

The `close_read_wakes_up` test has a race condition and only passes on windows if the `shutdown` happens before the `read`. This PR ignores the test on windows adds a sleep to make it more likely that the `read` happens before the `shutdown` and the test actually tests what it is supposed to test on other platforms.

I'm submitting this before any docs changes, so that we can find out on what platforms `shutdown` actually works as documented.

r? `@ChrisDenton`
  • Loading branch information
bors committed Mar 9, 2024
2 parents 0d69dc3 + adae314 commit f3f4fd0
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit f3f4fd0

Please sign in to comment.