Add "-Zrandomize-layout" flag #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I think this makes sense... though we don't even set this flag in Miri and maybe we should? |
|
Hm, a potential problem here is that people might have size assertions in their code which would fail now. |
|
Judging from this comment I think we want to disable the flag again, and instead make it easier for users to set their own rustflags (also for the sysroot build). Which is basically #8. |
|
FYI I reverted this PR, but you can now set RUSTFLAGS yourself to achieve the same effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
-Zrandomize-layoutflag toCAREFUL_FLAGS. This flag randomizes the layout ofrepr(Rust)types, to help catch code relying on unatable details of that layout.