fs: validate mode in ReadStream and WriteStream

Fixes: nodejs#37430
RaisinTen · Feb 18, 2021 · 90ed832 · 90ed832
1 parent bb35b6e
commit 90ed832
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/internal/fs/streams.js b/lib/internal/fs/streams.js
@@ -18,6 +18,7 @@ const {
 } = require('internal/errors').codes;
 const { deprecate } = require('internal/util');
 const {
+  parseFileMode,
   validateFunction,
   validateInteger,
 } = require('internal/validators');
@@ -168,7 +169,7 @@ function ReadStream(path, options) {
   // Path will be ignored when fd is specified, so it can be falsy
   this.path = toPathIfFileURL(path);
   this.flags = options.flags === undefined ? 'r' : options.flags;
-  this.mode = options.mode === undefined ? 0o666 : options.mode;
+  this.mode = parseFileMode(options.mode, 'options.mode', 0o666);
 
   importFd(this, options);
 
@@ -334,7 +335,7 @@ function WriteStream(path, options) {
   // Path will be ignored when fd is specified, so it can be falsy
   this.path = toPathIfFileURL(path);
   this.flags = options.flags === undefined ? 'w' : options.flags;
-  this.mode = options.mode === undefined ? 0o666 : options.mode;
+  this.mode = parseFileMode(options.mode, 'options.mode', 0o666);
 
   importFd(this, options);