Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix board runners to correctly detect dependencies #126

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

crclark96
Copy link
Contributor

the &> redirection literal is undefined behavior in sh, leading to
incorrect dependency detection --
https://github.com/koalaman/shellcheck/wiki/SC2039\#redirect-both-stdout-and-stderr

before:
2021-01-31_14-08-05

after:
2021-01-31_14-11-17

the `&>` redirection literal is undefined behavior in `sh`, leading to
incorrect dependency detection --
https://github.com/koalaman/shellcheck/wiki/SC2039\#redirect-both-stdout-and-stderr
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, thanks for catching this!

@Rahix Rahix changed the title fixes board runners to correctly detect dependencies Fix board runners to correctly detect dependencies Feb 1, 2021
@Rahix Rahix merged commit 3e0cefc into Rahix:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants