Changes from #93, cleaned and rebased on master #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ToddG, can you quickly give me an ok/not ok for this PR? I'd like to get those changes in so we can then properly look at your I2C slave driver. :) |
explicite
reviewed
Nov 18, 2020
Closed
ToddG
approved these changes
Nov 25, 2020
Instead of having each chip HAL define the register and field names, we
have decided to fix these on PAC level such that all chips use the same
names. Thus, simplify the `impl_twi_i2c!{}` macro and name registers
directly instead of a large amount of macro tokens.
Co-authored-by: Rahix <rahix@rahix.de>
All constructors for the I2C master driver do the same thing for configuring the bus speed. Split this out into a common method instead of duplicating the code. Co-authored-by: toddg <toddg@zwrob.com> Signed-off-by: Rahix <rahix@rahix.de>
In preparation for a future addition of an I2C slave driver, rename the I2C master driver to `I2cMaster`. To ease migration, add a type-alias for the old name which is marked as deprecated. This alias will be removed at a later time when most users have switched to the new name. Co-authored-by: toddg <toddg@zwrob.com> Signed-off-by: Rahix <rahix@rahix.de>
Rahix
force-pushed
the
toddg-i2c-changes-rebased
branch
from
0735300 to
f895af8
Compare
|
Thanks @ToddG! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @ToddG,
I've isolated the separate changes from your PR (#93) now. I have taken a bit of liberty in doing so and did some additional changes to make everything work well (for the most part minor fixes and deprecation aliases to ease updating). Please take a look at the individual commits whether they reflect your original intent and whether it is okay for you to have your name tagged on them in this form :)
If everything is alright for you, I'd merge these as they are. Then, the only remaining change in your PR should be the actual I2C slave driver. Please rebase your work ontop of master after this PR here is merged such that only the slave-driver changes remain in there.