Add ATmega128RFA1 support #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds basic ATmega128RFA1 support. Adjusts the common USART patches for UCSZ? slightly to work with the ATmega128RFA1's ATDF.
Rahix
approved these changes
Mar 7, 2022
|
Sounds good to me. HAL integration seems fine with those peripherals (GPIO/SPI) so I'd like to say I'm confident with the rest, but fixing when those comes up seems smart :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic ATmega128RFA1 support.
This has been partially tested (GPIO, SPI) with changes I've got pending to
avr-hallibraries, but I don't have a good enough development board to test the other peripherals more than ensuring they build.This PR also adjusts the common USART patches for
UCSZ?slightly to work with the ATmega128RFA1's ATDF. The ATDF does specify enum values for the field but the patch was not_replace_enum. I've changed the common patch to use_replace_enum, to make sure the fields are consistent with other micros.