Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split INT field into 2 bits for atmega328 and atmega328pb #74

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

gpgreen
Copy link
Contributor

@gpgreen gpgreen commented Feb 5, 2021

The INT0 and INT1 fields in the EIMSK register were incorrectly
combined into a 2 bit field, split into individual bits
Allowed write access to PRR0 and PRR1 in atmega328pb

The INT0 and INT1 fields in the EIMSK register were incorrectly
combined into a 2 bit field, split into individual bits
Allowed write access to PRR0 and PRR1 in atmega328pb
@gpgreen
Copy link
Contributor Author

gpgreen commented Feb 5, 2021

I downloaded the atmega328pb datasheet and compared with the generated svd. It had the same problems with the EIMSK and PRR registers (multiple in this case). So I went ahead and added those also.

Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Rahix Rahix merged commit ca6cad6 into Rahix:master Feb 5, 2021
@gpgreen gpgreen deleted the fix_atmega328p_exint branch February 5, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants