Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all llvm_asm macros #106

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Remove all llvm_asm macros #106

merged 1 commit into from
Aug 9, 2022

Conversation

mbuesch
Copy link
Contributor

@mbuesch mbuesch commented Aug 8, 2022

Remove all llvm_asm! macros and require a recent compiler with asm! support.
As discussed in #104

@mbuesch
Copy link
Contributor Author

mbuesch commented Aug 8, 2022

Update: Removed the compile_error, because it doesn't work. The compile aborts at the earlier feature request.

@mbuesch
Copy link
Contributor Author

mbuesch commented Aug 8, 2022

CI fails due to ancient compiler nightly-2021-01-07, as expected.

@mbuesch
Copy link
Contributor Author

mbuesch commented Aug 8, 2022

Update: Remove now unnecessary build dependency rustversion.

@mbuesch mbuesch mentioned this pull request Aug 8, 2022
Merged
Rahix
Rahix reviewed Aug 9, 2022
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for taking care of this! I have one minor nit, everything else looks great!

src/lib.rs Outdated Show resolved Hide resolved
@Rahix
Copy link
Owner

Rahix commented Aug 9, 2022

Ah, and CI is failing because it is still using the old nightly. I'll push a commit to upgrade it, then you can rebase to (hopefully) get it to pass.

@Rahix
Copy link
Owner

Rahix commented Aug 9, 2022

Done in commit 2e8d033 ("ci: Upgrade to a new compiler version"). Please rebase when you find the time :)

@mbuesch
Copy link
Contributor Author

mbuesch commented Aug 9, 2022

Thanks. I pushed an updated branch.

Rahix
Rahix approved these changes Aug 9, 2022
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Rahix Rahix merged commit bfccae0 into Rahix:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahix Rahix Rahix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbuesch @Rahix