Emit alternateGroup element in SVD for registers with multiple modes
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the capability to emit an `alternateGroup` element in
the resulting SVD when a register of a peripheral has multiple modes.
This is handy for the modern timer peripherals in the atxmegas and new
attinys where a timer can be either set to 16 bit single mode or you can
split it into two independent 8 bit timers.
The resulting registers are prefixed with the mode already by `svd2rust`
as of version v0.18.0. For example in an attiny817 for peripheral TCA0
there will be `single_ctrl{a,b,c}` and `split_ctrl{a,b,c}` registers.
Rahix
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Very nice, thanks a lot for the contribution!
Can you also add the ATtiny817 as a regression test in tests/regression.rs please? To do this, you'll need to:
- Add the ATDF source file
- Add the testcase in the mentioned file
- Run
cargo insta testto generate the new snapshot - Run
cargo insta reviewto accept the snapshot - Then check in both the ATDF and the snapshot into git.
|
Done. Do you want me to fix the rustfmt fail as well? |
Yes please :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the capability to emit an
alternateGroupelement in the resulting SVD when a register of a peripheral has multiple modes. This is handy for the modern timer peripherals in the atxmegas and new attinys where a timer can be either set to 16 bit single mode or you can split it into two independent 8 bit timers.The resulting registers are prefixed with the mode already by
svd2rustas of version v0.18.0. For example in an attiny817 for peripheral TCA0 there will besingle_ctrl{a,b,c}andsplit_ctrl{a,b,c}registers.This should fix #30