Error hovering over MH/OH - Classic anniversary

[padkipz]

Currently getting the following error when I hover over OH/MH.

Trinkets continue to work, and belt/boots work prior to hovering over OH/MH, but then stop working.

[string "@Blizzard_FrameXMLUtil/Cooldown.lua"]:3: in function 'CooldownFrame_Set'
[string "@GearMenu/gui/GM_Cooldown.lua"]:87: in function 'UpdateGearSlotCooldown'
[string "@GearMenu/gui/GM_GearBar.lua"]:367: in function 'func'
[string "@GearMenu/gui/GM_GearBar.lua"]:206: in function 'UpdateGearBars'
[string "@GearMenu/code/GM_Core.lua"]:136: in function 'OnEvent'
[string "*GM_Frame.xml:8_OnEvent"]:1: in function <[string "*GM_Frame.xml:8_OnEvent"]:1>

Locals:
Skipped (In Encounter)

[padkipz]

On further testing, this seems to be a specific issue with having a Manual Crowd Pummeler in your bags at 0 charges.

[RagedUnicorn]

Hi @padkipz

Thanks for reporting this. I guess this is kind of a special case where a weapon can have a cooldown which is rather rare I guess. Can you confirm that there is a cooldown when crowd pummeler is activated?

Besides that I think there is some part missing from the error that you copied. If you can reproduce it can you check if there is more to that error message. This just shows where it happened but not exactly what failed.

Cheers
RagedUnicorn

[RagedUnicorn]

For my reference because I think it could be related to this issue that I once saw but wasn't able to reproduce.

Time: Thu Oct 17 22:47:23 2024
Count: 1
Stack: Interface/AddOns/Blizzard_FrameXMLUtil/Cooldown.lua:3: attempt to compare number with nil
[string "@Interface/AddOns/Blizzard_FrameXMLUtil/Cooldown.lua"]:3: in function `CooldownFrame_Set'
[string "@Interface/AddOns/GearMenu/gui/GM_TrinketMenu.lua"]:220: in function `UpdateTrinketMenuSlotCooldowns'
[string "@Interface/AddOns/GearMenu/code/GM_Core.lua"]:149: in function `OnEvent'
[string "*GM_Frame.xml:8_OnEvent"]:1: in function <[string "*GM_Frame.xml:8_OnEvent"]:1>

Locals: self = GM_TrinketMenuFrameSlot_1_Cooldown {
 currentCooldownType = 2
}
start = nil
duration = nil
enable = true
forceShowDrawEdge = nil
modRate = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to compare number with nil"

[padkipz]

Hi @padkipz

Thanks for reporting this. I guess this is kind of a special case where a weapon can have a cooldown which is rather rare I guess. Can you confirm that there is a cooldown when crowd pummeler is activated?

Besides that I think there is some part missing from the error that you copied. If you can reproduce it can you check if there is more to that error message. This just shows where it happened but not exactly what failed.

Cheers RagedUnicorn

No the item itself has no cooldown, it's just a 30 second duration on the buff.

As far as I can tell, that is the full error message, minus the line at the top:
390x Blizzard_FrameXMLUtil/Cooldown.lua:3: attempt to compare number with nil

[RagedUnicorn]

Ah perfect thanks. That first line was what interested me mostly. For me that issue happened once or twice when I died and released to Spirit but I can't reproduce it. I added some safety checks when retrieving the cooldown of an item. I think that should help in case no cooldown is returned. Will include this in the next release (hopefully end of week)

[RagedUnicorn]

This was deployed with 2.4.0, please let me know in case you still encounter the issue.

Cheers,
RagedUnicorn